OCPNODE-4521: Use programmatic skip for single-node instead of test name tag - #31486
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@saschagrunert: This pull request references OCPNODE-4521 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@haircommander @mrunalp @rphillips @cpmeadors could one of you approve this? It unblocks the AdditionalStorageConfig feature gate promotion (openshift/api#2858). |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe test replaces the ChangesSingle-node test handling
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
openshift-ci
Bot
added
the
ready-for-human-review
|
Scheduling required tests: |
|
/approve |
openshift-ci
Bot
added
lgtm
|
/retest |
1 similar comment
|
/retest |
openshift-ci
Bot
added
the
needs-rebase
|
/retest-required |
|
@saschagrunert can you rebase? |
…ame tag Remove [Skipped:SingleReplicaTopology] from the Describe string and use a programmatic skip via IsSingleNode() in BeforeEach instead. The tag in the test name changed the SHA-256 hash used for deterministic sharding, which moved the test from shard 2of2 to 1of2 and reset all Sippy run counts to zero. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
bec58d2 to
a7a02f0
Compare
|
@haircommander done. ✔️ |
openshift-ci
Bot
removed
the
needs-rebase
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpmeadors, haircommander, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Scheduling required tests: |
|
Job Failure Risk Analysis for sha: a7a02f0
|
|
/test e2e-gcp-ovn |
|
/verified by @BhargaviGudi |
openshift-ci-robot
added
the
verified
|
@BhargaviGudi: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@saschagrunert: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
Remove
[Skipped:SingleReplicaTopology]from theDescribestring and use a programmatic skip viaIsSingleNode()inBeforeEachinstead.The tag in the test name changed the SHA-256 hash used for deterministic sharding (
pkg/test/ginkgo/sharder.go), which moved the test from shard2of2to1of2and reset all Sippy run counts to zero. This blocks the feature gate promotion in openshift/api#2858.This reverts the test name to its original form (from #31439) while preserving the single-node skip behavior.
Summary by CodeRabbit